New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Distutils removal #4544
base: master
Are you sure you want to change the base?
fix: Distutils removal #4544
Conversation
tests/unit/test_chainer.py
Outdated
@@ -173,7 +172,7 @@ def test_additional_hyperparameters(sagemaker_session, chainer_version, chainer_ | |||
framework_version=chainer_version, | |||
py_version=chainer_py_version, | |||
) | |||
assert bool(strtobool(chainer.hyperparameters()["sagemaker_use_mpi"])) | |||
assert chainer.hyperparameters()["sagemaker_use_mpi"] in ('y', 'yes', 't', 'true', 'on', '1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what strtobool was doing so left it the exact same.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4544 +/- ##
==========================================
- Coverage 87.50% 87.37% -0.13%
==========================================
Files 391 389 -2
Lines 37098 36773 -325
==========================================
- Hits 32461 32132 -329
- Misses 4637 4641 +4 ☔ View full report in Codecov by Sentry. |
e79304d
to
e9e08a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bot run pr
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
e9e08a3
to
d8496ac
Compare
It looks like there are tests still running on python 3.7. I'm not sure how sagemaker is able to be installed/functions in a 3.7 miniconda environment but it's not supported. Seems like the job runner needs an update since 3.7 has been end of life since June 2023. The errors come from this env: /miniconda3/lib/python3.7/site-packages/sagemaker_training/process.py |
Also remove from tests. Closes aws#4534
d8496ac
to
50bd9b0
Compare
Just let me know if I need to rebase once the python 3.7 issue is taken care of. |
@jmahlik Kindly take a look at the failing integ-tests. |
They are failing from a python 3.7 environment slipping into the test suite. All of them have a similar traceback. I believe this can be traced to the pytorch framework version being out of date, so the image has python 3.7 installed. It doesn't appear pytorch 1.5 is supported on the images page. @knikure Would it be ok to bump the tests to use 2.1.2 so they are run on a supported python version? I'm not so familiar with the support policy for framework images and couldn't find firm docs on what exactly is supported by the sdk for training. One might imagine with an unsupported python, the image becomes obsolete. Traceback: ClientError: AlgorithmError: framework error:
Traceback (most recent call last):
File "/miniconda3/lib/python3.7/site-packages/sagemaker_containers/_trainer.py", line 84, in train
entrypoint()
File "/miniconda3/lib/python3.7/site-packages/sagemaker_sklearn_container/training.py", line 39, in main
train(environment.Environment())
File "/miniconda3/lib/python3.7/site-packages/sagemaker_sklearn_container/training.py", line 35, in train
runner_type=runner.ProcessRunnerType)
File "/miniconda3/lib/python3.7/site-packages/sagemaker_training/entry_point.py", line 100, in run
wait, capture_error
File "/miniconda3/lib/python3.7/site-packages/sagemaker_training/process.py", line 291, in run
cwd=environment.code_dir,
File "/miniconda3/lib/python3.7/site-packages/sagemaker_training/process.py", line 208, in check_error
info=extra_info,
sagemaker_training.errors.ExecuteUserScriptError: ExecuteUserScriptError:
ExitCode 1
ErrorMessage ""
Command "/bin/sh -c ./_repack_script_launcher.sh --dependencies . Retrying.. Framework example for a failing test: sagemaker-python-sdk/tests/integ/sagemaker/workflow/test_retry.py Lines 166 to 174 in 55822f7
|
Closes #4534
Issue #, if available: #4534
Description of changes: Remove runtime dependency on setuptools. Remove reliance on deprecated distutils.
Testing done: Unit, these functions are drop in replacements now that dirs_exist_ok is a parameter in shutil.copytree.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.