Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid AccessDenied error for a while on SageMaker Studio wtih do… #4600

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heechan-marvin
Copy link

…main isolation configured.

*Issue #, if available: NA

*Description of changes:

When you create training job on SageMaker Studio[1] by calling Estimator.fit function, SageMaker automatically adds tags such as sagemaker:domain-arn so that you could make use of them for domain Isolation[2].

However, tag propagation takes some time, even if it is tiny. Estimator.fit function calls Session.logs_for_job
by default and this function calls DescribeTrainingJob API right after it calls CreateTrainingJob API. This causes AccessDenied error until tags such as sagemaker:domain-arnare added by SageMaker.

The change this pull request introduces ignores AccessDenied error when Estimator.fit function calling the first DescribeTrainingJob API for some time to give enough time for tag propagation.

+++++++
Reference
+++++++
[1] https://docs.aws.amazon.com/sagemaker/latest/dg/studio.html
[2] https://docs.aws.amazon.com/sagemaker/latest/dg/domain-resource-isolation.html

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@heechan-marvin heechan-marvin requested a review from a team as a code owner April 21, 2024 09:22
@heechan-marvin heechan-marvin requested review from liujiaorr and removed request for a team April 21, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant