Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading redux-offline and netinfo dependencies for react native #551

Merged
merged 3 commits into from Jul 8, 2020

Conversation

Ashish-Nanda
Copy link
Contributor

Issue #, if available:

Description of changes:
Upgrading redux-offline and netinfo dependencies for react native to use latest versions. This is because newer versions of NetInfo deprecated some APIs that were used by the version of redux-offline we were using.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ucallQA
Copy link

ucallQA commented May 17, 2020

is there an ETA when this will be merged?

@DrWorkhard
Copy link

Waiting for this as well, if I understand correctly this makes amplify compatible with expo 37

@Ashish-Nanda
Copy link
Contributor Author

Ashish-Nanda commented May 26, 2020

@DrWorkhard we were waiting for @react-native-community/async-storage to be supported in expo because redux-offline has a dependency on it, and and this change would not work in Expo without it.

This just happened over the weekend: react-native-async-storage/async-storage#368 (comment)

We will probably test the change in both bare and expo managed apps and then merge the PR later this week.

@DrWorkhard
Copy link

@DrWorkhard we were waiting for @react-native-community/async-storage to be supported in expo because redux-offline uses has a dependency on it, and and this change would not work in Expo without it.

This just happened over the weekend: react-native-community/async-storage#368 (comment)

We will probably test the change in both bare and expo managed apps and then merge the PR later this week.

Thank you so much, good to hear and keep up the great work!

@duongvanba
Copy link

There are any way to apply this pull request for my projet?

@theharness
Copy link

theharness commented Jun 25, 2020

@Ashish-Nanda Any updates on timeframe? Looks like Expo SDK 38 just released with react-native-community/async-storage included.

@jvgaeta
Copy link

jvgaeta commented Jul 1, 2020

Any update on when this will be merged? Thanks!

@Ashish-Nanda
Copy link
Contributor Author

Hi,
Thank you for your patience. We realized the PR needs some more changes and have a bit more testing to do before we merge and release. We have prioritized this now, and aim to get it out before end of next week.

@amhinson
Copy link
Contributor

amhinson commented Jul 8, 2020

Tested apps generated with RN CLI & Expo with Verdaccio, and all seems to be working as expected 👍

@Ashish-Nanda
Copy link
Contributor Author

Tested apps generated with RN CLI & Expo with Verdaccio, and all seems to be working as expected 👍

Thanks for verifying @amhinson!

Copy link
Contributor

@amhinson amhinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ashish-Nanda ! 👍

@mikeRChambers610
Copy link

I don't understand, what is the fix for the issue? NPM install new aws packages? Which ones?

@theharness
Copy link

@mikeRChambers610 Just install the latest aws-app sync package and you’ll have the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants