Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gauge component to dashboard #2746

Closed

Conversation

gmuralidharreddy
Copy link
Collaborator

@gmuralidharreddy gmuralidharreddy commented Apr 23, 2024

This PR is for the ticket #2635

Now with these changes, we can able to add a Guage component in the dashboard. Since the gauge is to occupy a full widget, I made a few changes to the component.

Verify:

Screen.Recording.2024-05-03.at.4.13.48.PM.mov

@gmuralidharreddy gmuralidharreddy force-pushed the feat/gauge-to-dashboard branch 6 times, most recently from 802ce5c to 128cb18 Compare May 3, 2024 15:53
@gmuralidharreddy gmuralidharreddy marked this pull request as ready for review May 3, 2024 16:18
className='gauge-data-quality'
style={{ bottom: showName ? '36%' : '40%' }}
>
<div className='gauge-data-quality' style={{ bottom: '2%' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are using percentages, can you add some screenshots of this widget on the dashboard at various sizes. small / medium / large square, and then similarly, small / medium / large rectangles where we test short but wide rectangles / tall but skinny rectangles.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squares shape:
Small:
Screenshot 2024-05-06 at 12 58 10 PM
Medium :
Screenshot 2024-05-06 at 1 19 09 PM

Large:
Screenshot 2024-05-06 at 1 00 31 PM

Rectangle short & wide:
small:
Screenshot 2024-05-06 at 1 22 45 PM
Medium:
Screenshot 2024-05-06 at 2 09 28 PM
Large:
Screenshot 2024-05-06 at 2 09 56 PM

Rectangle tall & skinny:
small:
Screenshot 2024-05-06 at 2 11 41 PM

Medium:
Screenshot 2024-05-06 at 2 12 01 PM

Large:
Screenshot 2024-05-06 at 2 12 24 PM

Rectangle normal 3:4:
small:
Screenshot 2024-05-06 at 2 13 07 PM

Medium:
Screenshot 2024-05-06 at 2 14 11 PM

Large:
Screenshot 2024-05-06 at 2 14 24 PM

@gmuralidharreddy gmuralidharreddy force-pushed the feat/gauge-to-dashboard branch 2 times, most recently from c9a2e00 to b57e3fa Compare May 6, 2024 08:52
@corteggiano
Copy link
Contributor

it looks great locally! thank you for the work
i noticed a couple of issues:

  1. dragging the widget around the dashboard is pretty buggy/inconsistent. the widget should be draggable from anywhere on the tile and should perform as well as the other widgets. ( i think this is related to the tooltip bug which is fixed so try rebasing from RC branch)
  2. widget title does not appear on widget
image
  1. properties color does not match gauge color and changing the property color doesnt change gauge color
image
  1. cant add thresholds
image

@gmuralidharreddy
Copy link
Collaborator Author

it looks great locally! thank you for the work i noticed a couple of issues:

  1. dragging the widget around the dashboard is pretty buggy/inconsistent. the widget should be draggable from anywhere on the tile and should perform as well as the other widgets. ( i think this is related to the tooltip bug which is fixed so try rebasing from RC branch)
  2. widget title does not appear on widget
image 3. properties color does not match gauge color and changing the property color doesnt change gauge color image 4. cant add thresholds image
  1. Rebased from RC.
  2. 2,3 & 4 These three are going to be done as part of Customization in the config panel ticket: ([Gauge] - Customize Gauge Widget in Dashboard #2634)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants