chore(scene composer): addressing react-hook linter warnings #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumanity
force-pushed
the
react-hook-cleanup
branch
5 times, most recently
from
817a131
to
972ea37
Compare
mumanity
force-pushed
the
react-hook-cleanup
branch
from
972ea37
to
7dfc0ed
Compare
hwandersman
reviewed
May 9, 2024
| @@ -294,7 +310,7 @@ export function AsyncLoadedAnchorWidget({ | |||
| lines.layers.disable(Layers.RaycastAndRender); | |||
| lines.layers.enable(Layers.RenderOnly); | |||
| } | |||
| }, [linesRef.current]); | |||
There was a problem hiding this comment.
Isn't it necessary to wait for the ref to update?
|
Did you manually update these or did you use the linter to auto-fix the warnings? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addressing a portion of the linter warnings from the implementation of
react-hooklinter on Scene Composer. Takes us from 712 to 672 warnings.Updates include:
Verifying Changes
Scene Composer
For
scene-composerpackage changes specifically, you can preview the component in the published storybook artifact. To do this, wait for thePublish Storybookaction to complete below.To run the storybook build locally, you need a local static web server:
Then open the website http://localhost:8080 to run the doc site.
Legal
This project is available under the Apache 2.0 License.