Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Aws marketplace integration #43

Merged
merged 21 commits into from
Jun 11, 2024
Merged

feat: Aws marketplace integration #43

merged 21 commits into from
Jun 11, 2024

Conversation

suhussai
Copy link
Contributor

@suhussai suhussai commented May 15, 2024

Issue # 50

Closes #.

Reason for this change

AWS Marketplace is a great mechanism to help SaaS vendors find new customers and handle billing operations. This PR incorporates a CDK-version of the marketplace quickstart.

Description of changes

This PR adds a new set of constructs to enable SaaS vendors to integrate marketplace with SBT. This helps with onboarding, offboarding and handling billing events.

Description of how you validated changes

Performed e2e testing with an example marketplace offering.

Checklist


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link
Contributor

@tobuck-aws tobuck-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding a brief description of this to the README? Also, please update the PR template with answers to the questions: "reason for the change, description of change" etc.

@suhussai suhussai force-pushed the aws-marketplace branch 2 times, most recently from 500f50c to 3ab572a Compare May 30, 2024 20:52
@suhussai suhussai requested a review from tobuck-aws May 30, 2024 23:11
@rupetnar rupetnar added the enhancement New feature or request label Jun 3, 2024
Copy link
Contributor

@tobuck-aws tobuck-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, this looks almost exactly like the quick start, except as CDK. @suhussai, I agree with your comments that we can borrow a lot of their documentation. I do think we need to have that on that on backlog @rupetnar, and prioritized appropriately. It's probably OK to merge this as is, but again, docs should be coming soon.

@tobuck-aws
Copy link
Contributor

@ujwalbukka looks like you have an unresolved conversation in this PR. See my comments above and let me know if you agree. If so, please resolve the thread. If not, let's chat about what should be done before merging. Thanks!

This commit adds a new documentation file 'marketplace-integration.md' that provides an overview of the AWS Marketplace integration with SBT. It covers topics such as how the integration works, the resources created, creating the Marketplace constructs, interaction with SBT, metering with AWS Marketplace, and customization options.

Additionally, it updates the README.md file to include a link to the new documentation file.
@suhussai suhussai merged commit 0704d1d into main Jun 11, 2024
8 checks passed
@suhussai suhussai deleted the aws-marketplace branch June 11, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants