Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BatchVisibility listener method parameter (#832) #1146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clementdenis
Copy link

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

Implementation for #832

This is only a crude implementation (see TODO in QueueMessageVisibility) but should work good enough.

Note: there's an API change on the VisibilityHandlerMethodArgumentResolver constructor, but there shouldn't be any reason to use this class directly.

馃挕 Motivation and Context

See #832

馃挌 How did you test it?

Through unit / integration tests

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

馃敭 Next steps

Maybe rework QueueMessage(Batch)Visibility to be more similar to acknowledgment design (using a callback).

@github-actions github-actions bot added component: sqs SQS integration related issue type: documentation Documentation or Samples related issue labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sqs SQS integration related issue type: documentation Documentation or Samples related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant