Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MessagingMessageConverter to SQS Auto-configuration (#1145) #1150

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

imsosleepy
Copy link

@imsosleepy imsosleepy commented May 12, 2024

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

Changed to allow the creation of a MessagingMessageConverter bean, and to allow auto configuration to be used even if a custom MessagingMessageConverter bean is declared.

馃挕 Motivation and Context

Implementation for issue #1145

馃挌 How did you test it?

Pass SqsAutoConfigurationTest, SqsAutoConfigurationIntegrationTest

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

馃敭 Next steps

@github-actions github-actions bot added the component: sqs SQS integration related issue label May 12, 2024
@imsosleepy imsosleepy changed the title Add MessagingMessageConverter to SQS Auto-configuration #1145 Add MessagingMessageConverter to SQS Auto-configuration (#1145) May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sqs SQS integration related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants