Draft: Cloudwatch publisher opt in

[krimsz]

📢 Type of change

• Bugfix
• New feature
• [X ] Enhancement
• Refactoring

📜 Description

Enable CloudWatch metrics if dependency is in the path

💡 Motivation and Context

Enhancement #345

💚 How did you test it?

In progress...

📝 Checklist

In progress...

• I reviewed submitted code
• I added tests to verify changes
• I updated reference documentation to reflect the change
• All tests passing
• No breaking changes

🔮 Next steps

Still a draft, wip

[maciejwalkowiak]

Thanks guys for a PR! I left few comments after quick look. I'll wait with deeper review till you make it non-draft..? Or is there something specific you would like to get feedback on before?

Hint: run make format before pushing or build with make build to avoid having CrossRegionS3Client modified.

[krimsz]

Hey @maciejwalkowiak its just me although it shows 2 people (changed laptops and forgot to change my git user to push a couple commits, will amend that before removing the draft status)

Still working on it, tests are failing here because no region provider (worked on my machine because I have a default REGION set locally). Will work on that, fix the things you mentioned and add the parameterstore and secretmanager because they are not following the normal autoconfiguration pattern.

The PR is a draft as I'm still workign on it, will notify when ready to review, just wanted to open it to show that it's actively worked on

[maciejwalkowiak]

Thanks @krimsz! Keep it going, great work and ping me in case you have any questions.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

No Coverage information
0.0% Duplication

[krimsz]

@maciejwalkowiak if you can please take a look at around how I'm creating (probably in a very wrong way) at AbstractAwsConfigDataLocationResolver . ParameterStore and SecretsManager are being created differently but I seem to be unable to find the propper place and way to create my MetricsPublisher. Code looks very ugly and I would like to get some direction before I keep going this direction.

My main issue with the approach here (besides the ugliness since I don't have access to the full context with full bean creation) is how to test it properly. The way the clients hide the builder makes it impossible to access the metricsPublisher at all