Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce native support for config stores, core, SQS and SNS module #856

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Introduce native support for config stores, core, SQS and SNS module #856

wants to merge 11 commits into from

Conversation

MatejNedic
Copy link
Member

@MatejNedic MatejNedic commented Aug 1, 2023 •
edited

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Currently creating native image for using core, both configs, SQS and SNS work and polls on start of native executable.
Closes #673 and partially #468

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the component: core Core functionality related issue label Aug 1, 2023
@MatejNedic MatejNedic mentioned this pull request Aug 1, 2023
Closed
@github-actions github-actions bot added the component: sqs SQS integration related issue label Aug 2, 2023
@MatejNedic MatejNedic marked this pull request as ready for review August 2, 2023 18:58
@MatejNedic MatejNedic changed the title Draft: Introduce native support for config stores and core module Introduce native support for config stores, core and SQS module Aug 2, 2023
@github-actions github-actions bot added the component: sns SNS integration related issue label Aug 4, 2023
@MatejNedic MatejNedic added component: secrets-manager Secrets Manager integration related issue component: parameter-store Parameter Store integration related issue labels Aug 4, 2023
@MatejNedic MatejNedic changed the title Introduce native support for config stores, core and SQS module Introduce native support for config stores, core, SQS and SNS module Aug 4, 2023
@github-actions github-actions bot added the component: s3 S3 integration related issue label Aug 4, 2023
@romangr
Copy link

romangr commented Oct 17, 2023

@MatejNedic nice to see there's a movement towards native build support, are there any rough estimates when this PR will be merged?

@MatejNedic
Copy link
Member Author

Hey hey @romangr , hopefully soon! Will work on this during a weekend

@romangr
Copy link

romangr commented Oct 19, 2023

@MatejNedic cool, thank you for your work!

maciejwalkowiak
maciejwalkowiak reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to run all our integration tests in a context of native image? As much as I believe that this PR works, how can we ensure that all functionality added in the future also works in the context of native image?

...d-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/config/ConfigStoreAOT.java Outdated Show resolved Hide resolved
@MatejNedic MatejNedic mentioned this pull request Dec 23, 2023
Open
@MatejNedic MatejNedic mentioned this pull request Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejwalkowiak maciejwalkowiak maciejwalkowiak left review comments

@tomazfernandes tomazfernandes Awaiting requested review from tomazfernandes tomazfernandes is a code owner

Assignees
No one assigned
Labels
component: core Core functionality related issue component: parameter-store Parameter Store integration related issue component: s3 S3 integration related issue component: secrets-manager Secrets Manager integration related issue component: sns SNS integration related issue component: sqs SQS integration related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Native image SpringCloudClientConfiguration.properties file is missing
3 participants
@MatejNedic @romangr @maciejwalkowiak