doc clarification for issue 971 #979
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awspring#971 Clarify bean factory name overrides needed for a mix of @SqsListener acknowldgementMode usages with existing custom MessageListenerContainerFactory defined in the app.
iparadiso
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
the
type: documentation
There was a problem hiding this comment.
Hey @iparadiso, sorry for the long delay.
Left a comment here, please let me know if it makes sense to you.
Thanks.
| @@ -640,6 +640,8 @@ See <<FIFO Support>> for more information. | |||
| If any value is set, it will take precedence over the acknowledgement mode defined for the container factory options. | |||
| See <<Acknowledgement Mode>> for more information. | |||
|
|
|||
| NOTE: When using `acknowledgementMode`, if you are also defining any custom `SqsMessageListenerContainerFactory` bean, it is necessary to update the default bean name for `SqsMessageListenerContainerFactory` to the bean name of your custom factory. This will allow this annotation to override the acknowledgement mode in your factory. This can be achieved by creating and configuring a `SqsListenerConfigurer` bean. Refer to section <<Global Configuration for @SqsListeners>> for more information, and see <<Specifying a MessageListenerContainerFactory>> for more details about this bean naming caveat. | |||
There was a problem hiding this comment.
We prefer a more formal language than referring to the user as you.
Can you please rewrite it considering this? Feel free to take a look at the docs to get a feel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#971
Clarify bean factory name overrides needed for a mix of @SqsListener acknowledgmentMode usages with existing custom MessageListenerContainerFactory defined in the app.
馃摙 Type of change
馃摐 Description
Doc clarification for issue #971
馃挕 Motivation and Context
Helps clarify the reason for the following exception found when using custom MessageListenerContainerFactory and
acknowledgementModeannotation in the same app.No MessageListenerContainerFactory bean with name defaultSqsListenerContainerFactory found for endpoint names馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps