Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 - upgrade to latest size-plugin #3

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

kepi
Copy link
Contributor

@kepi kepi commented Feb 25, 2021

We needed generated json for our CI, which is available in latest size-plugin.

This simply upgrades dependencies to latest one. I wasn't sure about version but as it has little different behavior (i.e. it generates that needed json file automatically) and different upstream options, it seems that it need major version.

Maybe it would be better to have 3.x.x to be in par with size-plugin.

@axe312ger
Copy link
Owner

That should be fine, thank you!

@axe312ger axe312ger merged commit dd240e4 into axe312ger:master Mar 8, 2021
@axe312ger
Copy link
Owner

Published!

@moonmeister
Copy link
Contributor

This broke webpack 5 aka Gatsby v3 compatibility. see GoogleChromeLabs/size-plugin#40

@moonmeister
Copy link
Contributor

"resolutions": { "size-plugin": "^1.2.0" },

Works for now for yarn users

@axe312ger
Copy link
Owner

axe312ger commented Mar 9, 2021

Ohh no, sorry :(

Should we roll back the version update?

Or to v2.0.2 that seems to work with Webpack 5. Maybe @moonmeister could try with the resolutions if v2.0.2 of webpack-size works?

@kepi
Copy link
Contributor Author

kepi commented Mar 9, 2021

And I just wanted to upgrade to Gatsby v3 :)

Btw. that was exactly why I bumped version to 2.0.0 - counting on the fact that everybody have "^1.0.0" or something similar in dependencies, so it shouldn't break their system when upgrading. Another workaround would be to set gatsby-plugin-webpack-size version to 1.x.x - it should work even in npm.

@moonmeister
Copy link
Contributor

Ohh no, sorry :(

Should we roll back the version update?

Or to v2.0.2 that seems to work with Webpack 5. Maybe @moonmeister could try with the resolutions if v2.0.2 of webpack-size works?

2.0.2 works but included a bunch of extra workbox js files. I didn't want to deal with it so I reverted to the 1.2.0. But if we can figure that out then we may be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants