Doc fixes, minor examples cleanup #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avindra
commented
Jun 2, 2019
| @@ -1,5 +1,4 @@ | |||
| var fs = require('fs'); | |||
| var url = require('url'); | |||
There was a problem hiding this comment.
This is just an unused import.
|
|
||
| server.listen(PORT); | ||
|
|
||
| console.log("Examples running on " + PORT); |
There was a problem hiding this comment.
Had to read the source code to figure this out. Adding a console log for future devs
avindra
changed the title
* simplify language
bootstrap 4 is slightly smaller then 3.2.0 so it should also help load examples faster
surface user/consumer changes first
|
@felipewmartins rebased out the README fixes already merged can you have a look? it's focused on general local dev stuff, no source changes |
|
Hi @avindra |
genie-youn
pushed a commit
to genie-youn/axios
that referenced
this pull request
Sep 27, 2019
* README.md COOKBOOK.md: minor fixes * simplify language * ECOSYSTEM: create a few categories * Examples: log port listening to * upgrade bootstrap 3 -> 4 in examples bootstrap 4 is slightly smaller then 3.2.0 so it should also help load examples faster * categorize 0.19 items a little differently surface user/consumer changes first
This was referenced Jan 7, 2020
This was referenced Apr 3, 2020
Closed
This was referenced Apr 13, 2020
This was referenced Apr 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateStatusandejectfor the interceptorMinor: update to bootstrap 4 build in examples files