New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly pass agents to follow-redirects #2547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
If I get a chance I'll merge a few PRs and add them to the 0.19.1 release, this one (although a really good fix) doesn't seem urgent to ship right away If this is urgent for you, change the base to be the 0.19 PR branch and update the changelog and it'll go out on 0.19.1 |
also you'll need to update the |
This PR should be part of 0.19.1 because #2426 will introduce a regression in 0.19.1 for anyone using http(s)Agent. I'll update the base of this PR and the changelog. Not sure if a dist change is required because this is only a change to |
Closed in favor of yasuf#1 |
This fixes #2546