Throw better error if url doesnt exist #3111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shayneo I think it would be better to fix it. |
kfiri
reviewed
Aug 6, 2020
| @@ -66,6 +66,9 @@ Axios.prototype.request = function request(config) { | |||
|
|
|||
| Axios.prototype.getUri = function getUri(config) { | |||
| config = mergeConfig(this.defaults, config); | |||
| if (!config.url) { | |||
| throw new Error('url of ' + config.url + 'is invalid for axios request'); | |||
There was a problem hiding this comment.
If the config.url is falsey (such an empty string), wouldn't this error message be not indicative?
in this example, if the url is '' the error message would be 'url of is invalid for axios request'
|
Closing in favour of #3791 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3110
Throws a friendly error when url doesn't exist