Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Add tests to) document how multiple inceptors work #3564

Merged
merged 19 commits into from
Dec 22, 2021

Commits on Jan 16, 2021

  1. Add a group for the multiple-interceptors tests.

    The current test contains a lot of details that are worth being tested
    separately and also made explicit. This is what is coming with the next changes.
    wolframkriesing committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    7dc8984 View commit details
    Browse the repository at this point in the history
  2. Fix indentation.

    wolframkriesing committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    8ba3198 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6bd87c1 View commit details
    Browse the repository at this point in the history
  4. Indent.

    wolframkriesing committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    5f31559 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2021

  1. Make the test just test a tiny bit, as described.

    The more explicit the test, the better we can 1) describe what it does
    and use that for the docs to make them understandable 2) have a better
    explicit description of the API (in case we want to modify it) and 3) have
    a regression test when changing.
    wolframkriesing committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    37c061a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    287296f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    abdd29d View commit details
    Browse the repository at this point in the history
  4. Write a test showing that the responses are not merged or anything,

    only the last one in the chain is returned.
    wolframkriesing committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    3c9388d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f5910e9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4649677 View commit details
    Browse the repository at this point in the history
  7. Refactor, add another group of tests and pull helper function there.

    The previous change to also catch in the helper function was not needed
    for any of the tests above, so remove it and put it in the describe-block
    below where it is needed.
    Just trying to write the specific code needed, not more.
    Not sure about the impact for failing tests, I am glad about input.
    But the main intention here is to have minimal code, explicit tests and
    not too much generic code which might break itself eventually.
    wolframkriesing committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    2299a9d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9d1b7ee View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b492b3d View commit details
    Browse the repository at this point in the history
  10. Document "multiple interceptors".

    I just extracted the test descriptions from the new/modified tests.
    And I also learned that I should improve the test descriptions, the
    tests are just in a GIVEN-WHEN-THEN structure, so I can also use those
    terms better. Will do this next.
    wolframkriesing committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    56e877f View commit details
    Browse the repository at this point in the history
  11. Transfer the better readable descriptions as I changed them in the RE…

    …ADME back into the tests.
    
    After I had updated the README using the test descriptions I realized how
    the test descriptions can be improved, so I did this "moving" the learnings
    back into the code.
    wolframkriesing committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    4983c05 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    34ff58d View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    cc1bfdd View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Configuration menu
    Copy the full SHA
    8290f21 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Configuration menu
    Copy the full SHA
    d188ea5 View commit details
    Browse the repository at this point in the history