-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Add tests to) document how multiple inceptors work #3564
(Add tests to) document how multiple inceptors work #3564
Commits on Jan 16, 2021
-
Add a group for the multiple-interceptors tests.
The current test contains a lot of details that are worth being tested separately and also made explicit. This is what is coming with the next changes.
Configuration menu - View commit details
-
Copy full SHA for 7dc8984 - Browse repository at this point
Copy the full SHA 7dc8984View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ba3198 - Browse repository at this point
Copy the full SHA 8ba3198View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bd87c1 - Browse repository at this point
Copy the full SHA 6bd87c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f31559 - Browse repository at this point
Copy the full SHA 5f31559View commit details
Commits on Jan 17, 2021
-
Make the test just test a tiny bit, as described.
The more explicit the test, the better we can 1) describe what it does and use that for the docs to make them understandable 2) have a better explicit description of the API (in case we want to modify it) and 3) have a regression test when changing.
Configuration menu - View commit details
-
Copy full SHA for 37c061a - Browse repository at this point
Copy the full SHA 37c061aView commit details -
Add a test that explicitly shows that the order of interceptors is as…
… they were added.
Configuration menu - View commit details
-
Copy full SHA for 287296f - Browse repository at this point
Copy the full SHA 287296fView commit details -
Pull out reusable code, to make the tests more explicitly stating the…
… things they care about.
Configuration menu - View commit details
-
Copy full SHA for abdd29d - Browse repository at this point
Copy the full SHA abdd29dView commit details -
Write a test showing that the responses are not merged or anything,
only the last one in the chain is returned.
Configuration menu - View commit details
-
Copy full SHA for 3c9388d - Browse repository at this point
Copy the full SHA 3c9388dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5910e9 - Browse repository at this point
Copy the full SHA f5910e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4649677 - Browse repository at this point
Copy the full SHA 4649677View commit details -
Refactor, add another group of tests and pull helper function there.
The previous change to also catch in the helper function was not needed for any of the tests above, so remove it and put it in the describe-block below where it is needed. Just trying to write the specific code needed, not more. Not sure about the impact for failing tests, I am glad about input. But the main intention here is to have minimal code, explicit tests and not too much generic code which might break itself eventually.
Configuration menu - View commit details
-
Copy full SHA for 2299a9d - Browse repository at this point
Copy the full SHA 2299a9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d1b7ee - Browse repository at this point
Copy the full SHA 9d1b7eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for b492b3d - Browse repository at this point
Copy the full SHA b492b3dView commit details -
Document "multiple interceptors".
I just extracted the test descriptions from the new/modified tests. And I also learned that I should improve the test descriptions, the tests are just in a GIVEN-WHEN-THEN structure, so I can also use those terms better. Will do this next.
Configuration menu - View commit details
-
Copy full SHA for 56e877f - Browse repository at this point
Copy the full SHA 56e877fView commit details -
Transfer the better readable descriptions as I changed them in the RE…
…ADME back into the tests. After I had updated the README using the test descriptions I realized how the test descriptions can be improved, so I did this "moving" the learnings back into the code.
Configuration menu - View commit details
-
Copy full SHA for 4983c05 - Browse repository at this point
Copy the full SHA 4983c05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34ff58d - Browse repository at this point
Copy the full SHA 34ff58dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc1bfdd - Browse repository at this point
Copy the full SHA cc1bfddView commit details
Commits on Feb 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8290f21 - Browse repository at this point
Copy the full SHA 8290f21View commit details
Commits on Dec 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d188ea5 - Browse repository at this point
Copy the full SHA d188ea5View commit details