Fixing isAxiosError typings to take generics

[latipun7]

I'm trying to solve this issue from #3815, this removes a workaround as stated from this #3815 (comment)

Also, I make formatting changes. If you don't like it, I could drop it.

closes: #3815

[Guuz]

Whats the status on this?

[latipun7]

Whats the status on this?

I don't know. I already keep this pull sync with master branch. Need maintainer attention to approve this.

Sorry for ping @mzabriskie , @jasonsaayman 🙏

[latipun7]

bumped.

@jasonsaayman , please give review. I also edit some formatting. If you don't like it, I can revert the format, and update the commit.
Thank you.

[arfianadam]

This would be very useful. Bumping.

[justirva09]

waiting for this merge 👍🏻

[jasonsaayman]

This will have to go into Axios next as it will be a breaking change

[latipun7]

This will have to go into Axios next as it will be a breaking change

@jasonsaayman sorry if I'm wrong, I don't think this is breaking change, this is just kind of new feature since old behavior still acceptable without issue. This is still good:

let user: User = null;
try {
  const { data } = await axios.get('/user?ID=12345');
  user = data.userDetails;
} catch (error) {
  if (axios.isAxiosError(error)) {
    handleAxiosError(error);
  } else {
    handleUnexpectedError(error);
  }
}

but accept the custom interface:

interface ResponseData {
 // ...
};

interface RequestConfigData {
 // ...
};

let user: User = null;
try {
  const { data } = await axios.get('/user?ID=12345');
  user = data.userDetails;
} catch (error) {
  if (axios.isAxiosError<ResponseData, RequestConfigData>(error)) {
    handleAxiosError(error);
  } else {
    handleUnexpectedError(error);
  }
}

CMIIW

[arthurfiorette]

Why this is a breaking change? All generics have a default any type.

[jasonsaayman]

This has already fixed with new error handeling

[arfianadam]

@jasonsaayman what is the new error handling and how does it solve this problem?

[jasonsaayman]

I have already re-opened one of the other pull requests that deals with this.

[jasonsaayman]

Closing in favour of #4344