Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving proxy from env on redirect #4436

Merged
merged 12 commits into from May 11, 2022
Merged

Resolving proxy from env on redirect #4436

merged 12 commits into from May 11, 2022

Commits on Jan 31, 2022

  1. Fixing http adapter to recompute proxy on redirect 

    Redirections can target different hosts or change the protocol
from http to https or vice versa. When the proxy option is
inferred from the environment, it should be recomputed when
the protocol or host changes because the proxy host can differ
or even whether to proxy or not can differ.
    @mbargiel
    mbargiel committed Jan 31, 2022
    Copy the full SHA
    a48dcfb View commit details
    Browse the repository at this point in the history

  2. Fixing proxy protocol handling 

    1) setProxy now changes request options protocol when using a proxy with explicit protocol.
2) As a result, selection of the correct transport can be simplified.
3) Legacy agent selection needs to be moved done accordingly. (Is 'agent' option even still used?)
    @mbargiel
    mbargiel committed Jan 31, 2022
    Copy the full SHA
    7a86b8b View commit details
    Browse the repository at this point in the history

  3. Using proxy-from-env library to handle proxy env vars 

    The proxy-from-env library is a popular, lightweight library that is
very easy to use and covers a few more cases, not to mention it has
extensive test coverage.
    @mbargiel
    mbargiel committed Jan 31, 2022
    Copy the full SHA
    7a00a50 View commit details
    Browse the repository at this point in the history

  4. Fixing proxy auth handling

    @mbargiel
    mbargiel committed Jan 31, 2022
    Copy the full SHA
    706fe5b View commit details
    Browse the repository at this point in the history

  5. Adding test proving env vars are re-resolved on redirect

    @mbargiel
    mbargiel committed Jan 31, 2022
    Copy the full SHA
    0cf13cb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into feature/fix-proxy/resolve-from-env-on-redi… 

    …rect
    @mbargiel
    mbargiel committed Jan 31, 2022
    Copy the full SHA
    2a8d0b5 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Revert unnecessary change

    @mbargiel
    mbargiel committed Feb 1, 2022
    Copy the full SHA
    a00e179 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Merge branch 'master' into feature/fix-proxy/resolve-from-env-on-redi… 

    …rect
    @mbargiel
    mbargiel committed May 10, 2022
    Copy the full SHA
    9dcdc6e View commit details
    Browse the repository at this point in the history

  2. Fixing proxy beforeRedirect regression

    @mbargiel
    mbargiel committed May 10, 2022
    Copy the full SHA
    57befc3 View commit details
    Browse the repository at this point in the history

  3. Fixing lint errors

    @mbargiel
    mbargiel committed May 10, 2022
    Copy the full SHA
    2de3cab View commit details
    Browse the repository at this point in the history

  4. Revert "Fixing lint errors" 

    This reverts commit 2de3cab.
    @mbargiel
    mbargiel committed May 10, 2022
    Copy the full SHA
    d44952c View commit details
    Browse the repository at this point in the history

  5. Revert "Fixing proxy beforeRedirect regression" 

    This reverts commit 57befc3.
    @mbargiel
    mbargiel committed May 10, 2022
    Copy the full SHA
    29976b9 View commit details
    Browse the repository at this point in the history