Fixing instance.defaults.headers type #4557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an Axios instance with
Axios.create()
theheaders
config (as described in the README) is merged into the root ofinstance.default.headers
. These values are not accessible because the types forinstance.defaults.headers
do not include an index type to represent the arbitrary properties which are merged there.This PR includes this index type in the
instance.defaults.headers
object and includes validation that this works in thetest/typescript/axios.ts
file. Without the change inindex.d.ts
this test shows the following error: