Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing of timeout in index.d.ts #4934

Merged
merged 2 commits into from Sep 28, 2022
Merged

Improve typing of timeout in index.d.ts #4934

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84696a7
Improve typing of timeout in index.d.ts
mrcwbr Sep 1, 2022
bd66e10
Merge branch 'v1.x' into patch-1
jasonsaayman Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.d.ts
View file
Open in desktop
Expand Up @@ -266,6 +266,8 @@ export interface AxiosProgressEvent {
download?: boolean;
}

type Milliseconds = number;

export interface AxiosRequestConfig<D = any> {
url?: string;
method?: Method | string;
Expand All @@ -276,7 +278,7 @@ export interface AxiosRequestConfig<D = any> {
params?: any;
paramsSerializer?: ParamsSerializerOptions;
data?: D;
timeout?: number;
timeout?: Milliseconds;
timeoutErrorMessage?: string;
withCredentials?: boolean;
adapter?: AxiosAdapter;
Expand Down