Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exporting missing exports in type definition index.d.ts #5003

Merged
merged 1 commit into from Oct 5, 2022

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Oct 5, 2022

close #5001

index.d.ts exports class Axios, AxiosHeaders, AxiosError, CanceledError, but they are not exported in runtime code.

@trim21 trim21 changed the title fix: exporting missing exports in types index.d.ts fix: exporting missing exports in type definition index.d.ts Oct 5, 2022
@arthurfiorette
Copy link
Contributor

arthurfiorette commented Oct 5, 2022

Should this PR also export everything that axios v0 used to export? Maybe also add the newly exported AxiosHeaders class... i didn't saw it :)

@trim21
Copy link
Contributor Author

trim21 commented Oct 5, 2022

AxiosHeaders is already added to exports in this PR.

@trim21
Copy link
Contributor Author

trim21 commented Oct 5, 2022

Should this PR also export everything that axios v0 used to export? Maybe also add the newly exported AxiosHeaders class...

Just checkout v0, it exports Axios, AxiosError, CanceledError, so also already done.

@jasonsaayman
Copy link
Member

I will release 1.0.1 tonight with this change and anything else that is crucial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.0.0 wrong type definition, class AxiosError is not exported
3 participants