Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] v1.2.4 #5487

Merged
merged 2 commits into from
Jan 24, 2023
Merged

[Release] v1.2.4 #5487

merged 2 commits into from
Jan 24, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 22, 2023

Build info

  • Browser build (UMD) (./dist/axios.min.js) 31.2 kB (11.6 kB gzipped)
    • v1.2.0 - 29.6 kB
    • v1.1.3 - 26.7 kB
    • v1.1.2 - 26.6 kB
    • v1.1.0 - 26.7 kB
  • Browser build (ESM) (./dist/esm/axios.min.js) 28.5 kB (11 kB gzipped)
    • v1.2.0 - 26.9 kB
    • v1.1.3 - 25.3 kB
    • v1.1.2 - 25.2 kB
    • v1.1.0 - 25.2 kB

Release notes:

Bug Fixes

  • types: renamed RawAxiosRequestConfig back to AxiosRequestConfig; (#5486) (2a71f49)
  • types: fix AxiosRequestConfig generic; (#5478) (9bce81b)

Contributors to this release

@smolak
Copy link

smolak commented Jan 24, 2023

Hi. Can this be released soon, please? :)

@ubcent
Copy link

ubcent commented Jan 24, 2023

Hey guys! Please release that as soon as possible

@baptLesta
Copy link

🙏🏻

@orgads
Copy link

orgads commented Jan 24, 2023

Unfortunately, interceptors are still broken. Please see:

@xsjcTony
Copy link

xsjcTony commented Jan 24, 2023

#5034 is still an issue in v1.2.4 unfortunately :(

Error code:
image

Error message:

Type '{ Authorization: string; } | { setContentType: AxiosHeaderSetter; getContentType: AxiosHeaderGetter; hasContentType: AxiosHeaderTester; ... 12 more ...; Authorization: string; } | { ...; }' is not assignable to type 'AxiosHeaders | (Partial<RawAxiosHeaders & { Accept: AxiosHeaderValue; "Content-Type": AxiosHeaderValue; "Content-Length": AxiosHeaderValue; "User-Agent": AxiosHeaderValue; "Content-Encoding": AxiosHeaderValue; }> & Partial<...>) | undefined'.
  Type '{ setContentType: AxiosHeaderSetter; getContentType: AxiosHeaderGetter; hasContentType: AxiosHeaderTester; setContentLength: AxiosHeaderSetter; ... 11 more ...; Authorization: string; }' is not assignable to type 'AxiosHeaders | (Partial<RawAxiosHeaders & { Accept: AxiosHeaderValue; "Content-Type": AxiosHeaderValue; "Content-Length": AxiosHeaderValue; "User-Agent": AxiosHeaderValue; "Content-Encoding": AxiosHeaderValue; }> & Partial<...>) | undefined'.
    Type '{ setContentType: AxiosHeaderSetter; getContentType: AxiosHeaderGetter; hasContentType: AxiosHeaderTester; setContentLength: AxiosHeaderSetter; ... 11 more ...; Authorization: string; }' is not assignable to type 'Partial<RawAxiosHeaders & { Accept: AxiosHeaderValue; "Content-Type": AxiosHeaderValue; "Content-Length": AxiosHeaderValue; "User-Agent": AxiosHeaderValue; "Content-Encoding": AxiosHeaderValue; }> & Partial<...>'.
      Type '{ setContentType: AxiosHeaderSetter; getContentType: AxiosHeaderGetter; hasContentType: AxiosHeaderTester; setContentLength: AxiosHeaderSetter; ... 11 more ...; Authorization: string; }' is not assignable to type 'Partial<RawAxiosHeaders & { Accept: AxiosHeaderValue; "Content-Type": AxiosHeaderValue; "Content-Length": AxiosHeaderValue; "User-Agent": AxiosHeaderValue; "Content-Encoding": AxiosHeaderValue; }>'.
        Property 'setContentType' is incompatible with index signature.
          Type 'AxiosHeaderSetter' is not assignable to type 'AxiosHeaderValue | undefined'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants