fix: propagate stack-trace across async #5925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to add tests that exercise this, but wanted to validate the approach. |
ikonst
force-pushed
the
propagate-stack-trace
branch
from
12b0459
to
50e6752
Compare
|
LGTM, I'd also revert the changes introduced in this attempt #4624 |
|
If you revert it, you'd have no stack trace from what happened after the callback. |
|
A different solution might be to double-down on Node 12+ async stack traces by converting the callbacks to awaited promises. This way we don't have to track anything on our own, but we still have to be mindful of those "callback" boundaries. I'll try this approach in a separate PR and see what comes out better. |
|
No, wait, there are multiple non-awaits within node's own code related to HTTP and sockets. |
|
➡️ #5987 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2387.