Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backport): handle custom param serializer fn #6299

Open
wants to merge 1 commit into
base: v0.x
Choose a base branch
from

Conversation

JadeMugs
Copy link

Resolves issues #6274 and #6262.

Changes:

  • Re-added the custom param serializer function and fully handled its functionality.
  • Enabled the ability to pass both encode and serialize options in the paramsSerialize configuration parameter.

To ensure ease of maintenance, the implementation mirrors the one in v1.6.7 (latest version).

@briwa
Copy link

briwa commented Mar 18, 2024

I've done something similar here: #6263 together with issue #6262. I'm not sure if we need another PR for this because I've opened mine 3 weeks ago and nobody has taken up on it yet.

@Xusifob
Copy link

Xusifob commented Mar 21, 2024

Can this be merged ? I have a lot of "req is not defined" error and had to revert to 0.24.0

@briwa
Copy link

briwa commented Mar 29, 2024

Can this be merged ? I have a lot of "req is not defined" error and had to revert to 0.24.0

@Xusifob A similar patch is merged in #6263 and has been released in v0.28.1. It should solve the same issue that this PR is addressing See: 3021e0d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants