plumbing: pktline, rename sync buffer getter putter

plumbing/format/pktline/pktline.go

@@ -161,8 +161,8 @@ func Read(r io.Reader, p []byte) (l int, err error) {
 //
 // The error can be of type *ErrorLine if the packet is an error packet.
 func ReadLine(r io.Reader) (l int, p []byte, err error) {
-	buf := GetPacketBuffer()
-	defer PutPacketBuffer(buf)
+	buf := GetBuffer()
+	defer PutBuffer(buf)
 
 	l, err = Read(r, (*buf)[:])
 	if l < LenSize {

plumbing/format/pktline/pktline_bench_test.go

@@ -100,7 +100,7 @@ func BenchmarkReadPacket(b *testing.B) {
 	for _, tc := range cases {
 		r := strings.NewReader("")
 		b.Run(tc.name, func(b *testing.B) {
-			buf := pktline.GetPacketBuffer()
+			buf := pktline.GetBuffer()
 			for i := 0; i < b.N; i++ {
 				r.Reset(tc.input)
 				for {
@@ -113,7 +113,7 @@ func BenchmarkReadPacket(b *testing.B) {
 					}
 				}
 			}
-			pktline.PutPacketBuffer(buf)
+			pktline.PutBuffer(buf)
 		})
 	}
 }

plumbing/format/pktline/sync.go

@@ -2,24 +2,24 @@ package pktline
 
 import "sync"
 
-var byteSlice = sync.Pool{
+var pktBuffer = sync.Pool{
 	New: func() interface{} {
 		var b [MaxSize]byte
 		return &b
 	},
 }
 
-// GetPacketBuffer returns a *[MaxSize]byte that is managed by a
-// sync.Pool. The initial slice length will be 65520 (65kb).
+// GetBuffer returns a *[MaxSize]byte that is managed by a sync.Pool. The
+// initial slice length will be 65520 (65kb).
 //
 // After use, the *[MaxSize]byte should be put back into the sync.Pool by
-// calling PutByteSlice.
-func GetPacketBuffer() *[MaxSize]byte {
-	buf := byteSlice.Get().(*[MaxSize]byte)
+// calling PutBuffer.
+func GetBuffer() *[MaxSize]byte {
+	buf := pktBuffer.Get().(*[MaxSize]byte)
 	return buf
 }
 
-// PutPacketBuffer puts buf back into its sync.Pool.
-func PutPacketBuffer(buf *[MaxSize]byte) {
-	byteSlice.Put(buf)
+// PutBuffer puts buf back into its sync.Pool.
+func PutBuffer(buf *[MaxSize]byte) {
+	pktBuffer.Put(buf)
 }