Create Bootstrap documentation & styles for functioning mobile nav #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted by index.js" This reverts commit 832320c.
mmunro-ltrr
previously approved these changes
Sep 9, 2020
akslay
reviewed
Sep 11, 2020
akslay
reviewed
Sep 11, 2020
akslay
reviewed
Sep 11, 2020
akslay
reviewed
Sep 11, 2020
|
It looks like there's a weird overlap happening with the dropdowns (this is after refreshing the page at the mobile screen size). It looks like the problem is coming from JS somewhere. In the inspector, styles are being added dynamically. And if you uncheck all those styles, the dropdowns appear correctly. |
akslay
reviewed
Sep 11, 2020
akslay
reviewed
Sep 11, 2020
akslay
reviewed
Sep 11, 2020
akslay
reviewed
Sep 11, 2020
akslay
reviewed
Sep 11, 2020
akslay
reviewed
Sep 11, 2020
| @@ -109,6 +109,11 @@ | |||
| font-family: $font-family-sans-serif; | |||
| font-weight: 500; | |||
| } | |||
| // >>> Material design icons. | |||
| .material-icons { | |||
| font-size: inherit; | |||
There was a problem hiding this comment.
It looks like this style is preventing utility classes (like .display-3) from working as expected; it's not allowing the class to change the font size.
akslay
reviewed
Sep 11, 2020
mmunro-ltrr
approved these changes
Sep 25, 2020
joeparsons
approved these changes
Sep 25, 2020
trackleft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90