Closes #219: Change from Jekyll to Hugo, matching the changes in Twitter Bootstrap. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (partial update).
|
Local builds are still failing for this: the rollup configuration might be messed up, but we've also had problems in the past with not traversing links within the container that runs the build. |
trackleft
reviewed
Mar 3, 2021
trackleft
reviewed
Mar 3, 2021
joeparsons
reviewed
Mar 3, 2021
|
This file https://github.com/az-digital/arizona-bootstrap/blob/main/js/src/index.js#L14 Should be Maybe? |
|
This file path definitely needs to get updated to: arizona-bootstrap/js/src/index.js Line 14 in fbc63a2 (See twbs/bootstrap#32001) |
kevcooper
previously requested changes
Mar 3, 2021
trackleft
reviewed
Mar 4, 2021
…& `ourname` shortcode.
mmunro-ltrr
dismissed
kevcooper’s stale review
Should be resolved (extra bracket typo).
kevcooper
approved these changes
Mar 26, 2021
trackleft
approved these changes
Mar 26, 2021
|
|
||
| Should you require [build tools]({{< docsref "/getting-started/build-tools/#tooling-setup" >}}), they are included for developing {{< ourname >}} and its docs, but they're likely unsuitable for your own purposes. | ||
|
|
||
| <a href="{{ site.download.source }}" class="btn btn-bd-red" onclick="ga('send', 'event', 'Getting started', 'Download', 'Download source');">Download source</a> |
There was a problem hiding this comment.
Suggested change
| <a href="{{ site.download.source }}" class="btn btn-bd-red" onclick="ga('send', 'event', 'Getting started', 'Download', 'Download source');">Download source</a> | |
| <a href="{{< param "download.source" >}}" class="btn btn-bd-red" onclick="ga('send', 'event', 'Getting started', 'Download', 'Download source');">Download source</a> |
joeparsons
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.