Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #622: Apply routine dev dependency updates. #623

Merged
merged 7 commits into from Jan 6, 2023
Merged

Closes #622: Apply routine dev dependency updates. #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1c47735
Closes #622: Apply routine dev dependency updates.
mmunro-ltrr Dec 2, 2022
d2ea093
Bump more versions, copy twbs eslint config changes.
mmunro-ltrr Dec 14, 2022
b61cdf0
Apply a couple of more recent version bumps.
mmunro-ltrr Dec 16, 2022
c25131c
Fix rollup config, freeze terser, use English placeholder example tex…
mmunro-ltrr Dec 21, 2022
dfefd20
Remove the @rollup/plugin-commonjs dev dependency.
mmunro-ltrr Dec 22, 2022
b9d521c
Update npm-check-updates and re-run it.
mmunro-ltrr Jan 4, 2023
22cbf62
Apply further version number bumps.
mmunro-ltrr Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .eslintrc.json
View file
Open in desktop
Expand Up @@ -43,6 +43,7 @@
"error",
"after"
],
"prefer-template": "error",
"semi": [
"error",
"never"
Expand All @@ -54,6 +55,7 @@
"unicorn/no-array-method-this-argument": "off",
"unicorn/no-for-loop": "off",
"unicorn/no-null": "off",
"unicorn/no-typeof-undefined": "off",
"unicorn/no-unused-properties": "error",
"unicorn/no-useless-undefined": "off",
"unicorn/numeric-separators-style": "off",
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
@@ -1,4 +1,4 @@
FROM --platform=linux/amd64 node:16.18.0-bullseye-slim
FROM --platform=linux/amd64 node:16.19.0-bullseye-slim

ENV LANG C.UTF-8

Expand Down Expand Up @@ -38,7 +38,7 @@ RUN apt-get update \
&& chmod 755 /root \
&& touch /root/.npmrc \
&& chmod 644 /root/.npmrc \
&& npm install --location=global npm-check-updates@16.3.16 \
&& npm install --location=global npm-check-updates@16.6.2 \
&& curl 'https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip' -o /tmp/awscliv2.zip \
&& unzip -d /tmp /tmp/awscliv2.zip \
&& /tmp/aws/install \
Expand Down
2 changes: 1 addition & 1 deletion build/rollup.config.js
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@ if (BUNDLE) {
module.exports = {
input: path.resolve(__dirname, '../js/src/index.js'),
output: {
banner,
banner: banner(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
banner: banner(),
banner: banner(),
interop: 'amd',

Copy link
Member

@trackleft trackleft Dec 21, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See rollup/rollup#4611

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing this as an option in
https://rollupjs.org/guide/en/#outputinterop
and it does seem to break the build locally.

file: path.resolve(__dirname, `../dist/js/${fileDest}`),
format: 'umd',
globals,
Expand Down