Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sort-objects): add custom-ignore to enable customizable ignore rule #131

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KID-joker
Copy link
Contributor

Description

fixes #126

Additional context

Because json-schema does not support function type, it is converted through object.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
  • Read contribution guidelines.

@KID-joker KID-joker changed the title feat(sort-objects): add ignore-function to enable customizable ignore rule feat(sort-objects): add custom-ignore to enable customizable ignore rule Apr 22, 2024
@azat-io
Copy link
Owner

azat-io commented Apr 24, 2024

The idea for such an option is a good one. But don't you think the customization is overly complicated? Perhaps it would be better to use just variable names instead of functions?

@KID-joker
Copy link
Contributor Author

I don't quite understand what you mean. How do variable names solve the problem?

@rtatarinov
Copy link

@KID-joker does it allow to exclude the files with specific name? can u prodive an example for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: (sort-objects) option for destructuring only
3 participants