Skip to content

Commit

Permalink
Change minimum versions of Node and eslint in integration tests (#83)
Browse files Browse the repository at this point in the history
Node v16 is out of support. So we test against Node v18 and v20.

eslint 7 was released 4 years ago so its fair to not actively test again
eslint 6. Speculativiely adding eslint 9 tests but not sure if that will
work

Also fix testing of multiple eslint versions

We weren't doing custom installations of different eslint versions
so we were always only testing one eslint version!

Added eslint-v9 test directory but it fails right now so not adding it
to CI.
  • Loading branch information
azeemba committed Dec 30, 2023
1 parent e4a5603 commit 893c508
Show file tree
Hide file tree
Showing 9 changed files with 4,152 additions and 1,595 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/node.js.yml
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
node-version: [18.x, 20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand All @@ -29,7 +29,7 @@ jobs:
- run: npm ci
- run: npm run lint
- run: npm run test
- run: npm run integration test 6 7 8 # eslint versions
- run: npm run integration test 7 8 # eslint versions
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v2
with:
Expand Down

0 comments on commit 893c508

Please sign in to comment.