Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running tests against the correct versions of ESLint #84

Merged
merged 1 commit into from Jan 4, 2024

Conversation

Standard8
Copy link
Contributor

When I was looking at the logs of the integration runs, I noticed that the ESLint version was always 8.0.0, even for the different directories.

I realised that the npm ci had not been run, so ESLint was never installed for those sub-directories and so the tests are defaulting to the ESLint at the top-level directory.

This adds a ci option and adds it to the github actions.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (893c508) 82.35% compared to head (60e3083) 82.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files           1        1           
  Lines          51       51           
=======================================
  Hits           42       42           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeemba
Copy link
Owner

azeemba commented Jan 4, 2024

Thanks!

@azeemba azeemba merged commit 6fc5651 into azeemba:master Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants