Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted testcases for better pipe plugin #372

Merged
merged 1 commit into from Dec 6, 2022
Merged

Adjusted testcases for better pipe plugin #372

merged 1 commit into from Dec 6, 2022

Conversation

veewee
Copy link
Collaborator

@veewee veewee commented Dec 5, 2022

See php-standard-library/psalm-plugin#8

The static-analysis tests are slightly adjusted to ensure better coverage.

@veewee veewee mentioned this pull request Dec 5, 2022
Merged
veewee
veewee commented Dec 5, 2022
View reviewed changes
composer.json Outdated Show resolved Hide resolved
tests/static-analysis/Fun/pipe.php Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 5, 2022 •
edited

Pull Request Test Coverage Report for Build 3627143290

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.977%
Totals Coverage Status
Change from base Build 3605503193: 0.0%
Covered Lines: 3386
Relevant Lines: 3421
💛 - Coveralls

@veewee veewee requested a review from azjezz December 5, 2022 15:46
@azjezz
Copy link
Owner

azjezz commented Dec 5, 2022

plugin is merged.

azjezz
azjezz previously approved these changes Dec 5, 2022
View reviewed changes
@veewee veewee requested a review from azjezz December 6, 2022 06:46
@azjezz
Copy link
Owner

azjezz commented Dec 6, 2022

let's not release this, as i don't see any benefits down stream, the require-dev constraint is not enforced for users.

@veewee
Copy link
Collaborator Author

veewee commented Dec 6, 2022

Was thinking the same this morning. good!

@azjezz azjezz merged commit 929fa6c into azjezz:2.3.x Dec 6, 2022
@veewee veewee added Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Enhancement Most issues will probably ask for additions or changes. labels Dec 6, 2022
@veewee veewee added this to the 2.3.1 milestone Dec 6, 2022
azjezz pushed a commit that referenced this pull request Dec 20, 2022
@veewee @azjezz
chore: adjusted test cases for better pipe plugin (#372)
a63d1e6
azjezz pushed a commit that referenced this pull request Dec 21, 2022
@veewee @azjezz
chore: adjusted test cases for better pipe plugin (#372)
411c7c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees
No one assigned
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veewee @coveralls @azjezz