feat(Result): introduce Result::unwrapOr()
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
force-pushed
the
unwrap
branch
2 times, most recently
from
2d09858
to
922a7ce
Compare
Pull Request Test Coverage Report for Build 8833515353Details
💛 - Coveralls |
veewee
requested changes
Apr 25, 2024
simPod
force-pushed
the
unwrap
branch
2 times, most recently
from
2d4c29e
to
73b87bf
Compare
simPod
changed the title
unwrapResultOr()Result::unwrapOr()
veewee
added
Priority: Low
veewee
reviewed
Apr 25, 2024
I'd like to introduce a function that allows to get inner value from Result if success and allows to bypass throwing an exception from Failure by providing a default value.
Co-authored-by: Saif Eddin Gmati <29315886+azjezz@users.noreply.github.com>
Co-authored-by: Saif Eddin Gmati <29315886+azjezz@users.noreply.github.com>
Co-authored-by: Saif Eddin Gmati <29315886+azjezz@users.noreply.github.com>
azjezz
approved these changes
May 3, 2024
simPod
added a commit
to simPod/psl
that referenced
this pull request
May 6, 2024
* feat(Result): introduce `Result::unwrapOr()` I'd like to introduce a function that allows to get inner value from Result if success and allows to bypass throwing an exception from Failure by providing a default value. * Update src/Psl/Result/Failure.php Co-authored-by: Saif Eddin Gmati <29315886+azjezz@users.noreply.github.com> * Update src/Psl/Result/ResultInterface.php Co-authored-by: Saif Eddin Gmati <29315886+azjezz@users.noreply.github.com> * Update src/Psl/Result/Success.php Co-authored-by: Saif Eddin Gmati <29315886+azjezz@users.noreply.github.com> * style: fix --------- Co-authored-by: Saif Eddin Gmati <29315886+azjezz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to introduce a function that allows to get inner value from Result if success and allows to bypass throwing an exception from Failure by providing a default value.