Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vec versions of the unique functions #472

Merged
merged 1 commit into from
May 4, 2024
Merged

Add Vec versions of the unique functions #472

merged 1 commit into from
May 4, 2024

Conversation

BackEndTea
Copy link
Contributor

Vec counterparts for the Dict versions of these functions.

I noticed we did a lot of Vec\values(Dict\unique($iter)) like constructions in our codebase, since we wanted the unique values of an array, as a list.

@coveralls
Copy link

coveralls commented Apr 30, 2024 •
edited

Pull Request Test Coverage Report for Build 8895621319

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 98.786%
Totals Coverage Status
Change from base Build 8832169884: 0.005%
Covered Lines: 4395
Relevant Lines: 4449
💛 - Coveralls

@BackEndTea
Add Vec versions of the unique functions
c87201f 
Vec counterparts for the Dict versions of these functions
veewee
veewee approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@veewee veewee left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@veewee veewee added this to the 3.0.0 milestone May 3, 2024
@veewee veewee added Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. labels May 3, 2024
@veewee veewee requested a review from azjezz May 3, 2024 06:27
@veewee veewee merged commit 7efaf75 into azjezz:next May 4, 2024
14 checks passed
@BackEndTea
Copy link
Contributor Author

Thanks @veewee & @azjezz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee veewee approved these changes

@azjezz azjezz azjezz approved these changes

Assignees
No one assigned
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BackEndTea @coveralls @veewee @azjezz