Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure image path is for correct image type #3163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amielkelinkedin
Copy link
Contributor

Validation insuring the wrong imageType is not register for an imageVersion, which would prevent the possibility of activating a completely incorrect imageVersion for an ImageType.

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #3163 (b84cf6f) into master (ce1ee12) will decrease coverage by 0.03%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##             master    #3163      +/-   ##
============================================
- Coverage     41.75%   41.72%   -0.04%     
- Complexity     4764     4777      +13     
============================================
  Files           610      611       +1     
  Lines         40814    40962     +148     
  Branches       4731     4750      +19     
============================================
+ Hits          17043    17091      +48     
- Misses        22360    22454      +94     
- Partials       1411     1417       +6     
Impacted Files Coverage Δ
...zkaban/imagemgmt/servlets/ImageVersionServlet.java 3.54% <0.00%> (-0.11%) ⬇️
...a/azkaban/jobcallback/JobCallbackRequestMaker.java 73.52% <70.58%> (+1.65%) ⬆️
...on/src/main/java/azkaban/utils/ValidatorUtils.java 50.00% <0.00%> (-10.00%) ⬇️
...azkaban/project/validator/XmlValidatorManager.java 75.65% <0.00%> (-4.91%) ⬇️
...n/imagemgmt/services/ImageRampRuleServiceImpl.java 72.54% <0.00%> (-4.29%) ⬇️
.../src/main/java/azkaban/jmx/JmxJobMBeanManager.java 65.62% <0.00%> (-3.13%) ⬇️
...ain/java/azkaban/project/AzkabanProjectLoader.java 78.88% <0.00%> (-1.50%) ⬇️
...kaban/imagemgmt/servlets/ImageRampRuleServlet.java 3.22% <0.00%> (-1.26%) ⬇️
...erver/src/main/java/azkaban/execapp/JobRunner.java 71.97% <0.00%> (-0.37%) ⬇️
.../src/main/java/azkaban/trigger/TriggerManager.java 15.25% <0.00%> (-0.07%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amielkelinkedin
Copy link
Contributor Author

This is currently blocked by Venice/Voldemort, using same image. Perhaps can unblock with automation that targets auto-registration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant