Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle buildscript refactor. #82

Merged
merged 1 commit into from Jul 21, 2022
Merged

Gradle buildscript refactor. #82

merged 1 commit into from Jul 21, 2022

Conversation

aemogie
Copy link
Contributor

@aemogie aemogie commented Jul 17, 2022

  1. Changed all methods to be called using ( ) and all quotation marks to be ". (Groovy supports ' as well, for some reason.)

  2. Created explicit :wrapper configuration, so all the configuration is in a single file. Uses 7.3.1-bin.

    • To get IntelliJ to use this, go to Settings | Build, Execution, Deployment | Build Tools | Gradle and change Use Gradle from: option to 'wrapper' task in Gradle build script.
    • Note: This will make IntelliJ run the :wrapper task every time you build, or run a Gradle task, so if you don't like that, switch it back. But make sure to run gradle :wrapper manually if you change the wrapper configuration.
  3. Removed redundant project variable referencing.

  4. Extracted the JUnit 4 version as an ext variable.

  5. Upgraded dependencies.

    • JOML 1.10.1 -> 1.10.4
    • JUnit 4.12 -> 4.13.2
  6. Reverted the test source directory from explicit src/main/test to the default src/test/java. (As specified by Maven's Standard Directory Layout)

  7. Removed manual Jar manifest entry.

  8. Added the MacOS-only JVM argument (-XstartOnFirstThread) to the application { } configuration.

    • I don't own a Mac, therefore I can't check if this works. Can someone else verify?
  9. Changed tasks creation to use tasks.register as the task is then configured only when the task is run. Reduces time used during the "Configuring" phase.

  10. Modified tasks :fatJar and :execute to act as aliases for :shadowJar and :runShadow respectively, as those replace the previous implementations.

Signed-off-by: aemogie <54412618+aemogie@users.noreply.github.com>
@athaun athaun self-assigned this Jul 18, 2022
@athaun athaun added enhancement New feature or request In review process Currently being reviewed by a project manager labels Jul 18, 2022
@athaun
Copy link
Member

athaun commented Jul 21, 2022

fabulous

@athaun athaun merged commit 5eeed98 into azurite-engine:main Jul 21, 2022
@athaun athaun removed the In review process Currently being reviewed by a project manager label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants