Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache monorepo package lookups #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdb8
Copy link

@jdb8 jdb8 commented Sep 27, 2021

I noticed that the rules call getPackages from get-monorepo-packages many times per execution, even when directory is the same (which I'd imagine it always is?). So just adding a module-level cache here saves us some work.

This isn't a huge time saving, but experimentally in a large monorepo I saw it shave off ~30s of total time on a ~2m run, which is non-negligible.

This PR assumes that it's safe to do this: if it's not safe, due to something I've overlooked, the alternative (better) approach is probably to add a config option allowing users to pass in a list of monorepo paths, so it doesn't need to be calculated at all by the plugin. Though if this is fine then it's less work since it doesn't require a new config option + documentation etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant