Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag props to grid and cell components #42

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wab
Copy link

@wab wab commented Jun 15, 2018

As proposed in this issue #41 ...

Which allows to do something like :

<Grid is="ul">
  <Cell is="li" width={3}>
    item 1
   </Cell>
   <Cell is="li" width={3}>
      item 2
    </Cell>
  </Grid>

Copy link
Owner

@azz azz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add docs?

package.json Outdated
@@ -27,6 +27,7 @@
"semantic-release": "semantic-release pre && npm publish && semantic-release post"
},
"peerDependencies": {
"clean-tag": "^1.0.4",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a regular dependency

@azz
Copy link
Owner

azz commented Jun 16, 2018

The lib doesn't have any docs? :(

@wab
Copy link
Author

wab commented Jun 16, 2018

It's a "sublib" of styled-system ...
https://github.com/jxnblk/styled-system/tree/master/clean-tag

@jacob-fueled
Copy link

@wab bump. would quite like the ability to specify the tag to which renders as it current either precludes semantic HTML or forces divitis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants