-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag props to grid and cell components #42
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add docs?
package.json
Outdated
@@ -27,6 +27,7 @@ | |||
"semantic-release": "semantic-release pre && npm publish && semantic-release post" | |||
}, | |||
"peerDependencies": { | |||
"clean-tag": "^1.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a regular dependency
The lib doesn't have any docs? :( |
It's a "sublib" of styled-system ... |
@wab bump. would quite like the ability to specify the tag to which renders as it current either precludes semantic HTML or forces divitis. |
As proposed in this issue #41 ...
Which allows to do something like :