Fix for the blank lines when entering fullscreen on Yosemite #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah! Great! This seems to work. I see the grey column as well, but better than missing the first line in FS mode ;) |
|
any news about it ? |
|
Does anyone know of a actively maintained MacVim fork? |
|
@jonashaag try @amadeus’ fork, specifically the yosemite-cherry-picked branch. |
|
Hm, neither the fix in this PR nor the fix here benoitc@9f77ac3 works for me... |
|
Hm, that didn't work either. I have version that works for me here: https://github.com/jonashaag/macvim/tree/yosemite I also set up automatic builds that you can download here: https://github.com/jonashaag/macvim/releases Maybe I'll also start integrating upstream vim patches / accept other patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a little re-arrangement of the methods, that are called during the fullscreen animation and it's almost working.
The problem: When the animation finishes a gray line appears on the right side of the screen. Call to
[self resizeWindowToFitContentSize:[vimView desiredSize] keepOnScreen:YES];at the end of all animations fixes it, but still for a second there's an annoying blink. If anyone has any clues how to fix this, it will be great.