Remove the lodash.assign dependency #393

fson · 2016-09-25T21:37:22Z

lodash.assign is deprecated:

npm WARN deprecated lodash.assign@4.2.0: This package is deprecated. Use Object.assign.

hzoo · 2016-09-27T12:48:36Z

We were doing this as part of https://github.com/babel/babel-eslint/pull/361/files but we can merge this one. can you fix the merge conflict?

lodash.assign is deprecated: ``` npm WARN deprecated lodash.assign@4.2.0: This package is deprecated. Use Object.assign. ```

fson · 2016-09-27T12:53:49Z

Thanks! Fixed.

jdalton · 2016-10-10T23:06:09Z

index.js


  // monkeypatch estraverse-fb (only for eslint < 2.3.0)
  try {
    var estraverseFb = eslintMod.require("estraverse-fb");
    estraverses.push(estraverseFb);
-    assign(estraverseFb.VisitorKeys, t.VISITOR_KEYS);
+    Object.assign(estraverseFb.VisitorKeys, t.VISITOR_KEYS);


lodash.assign is deprecated: ``` npm WARN deprecated lodash.assign@4.2.0: This package is deprecated. Use Object.assign. ```

fson mentioned this pull request Sep 25, 2016

Deprecated dependencies facebook/create-react-app#755

Closed

Remove the lodash.assign dependency

64b0af8

lodash.assign is deprecated: ``` npm WARN deprecated lodash.assign@4.2.0: This package is deprecated. Use Object.assign. ```

fson force-pushed the lodash-assign branch from da7265e to 64b0af8 Compare September 27, 2016 12:53

hzoo merged commit 4cf9ac1 into babel:master Sep 27, 2016

jdalton reviewed Oct 10, 2016

View reviewed changes

nicolo-ribaudo pushed a commit to babel/babel that referenced this pull request Nov 14, 2019

Remove the lodash.assign dependency (babel/babel-eslint#393)

ce6d9df

lodash.assign is deprecated: ``` npm WARN deprecated lodash.assign@4.2.0: This package is deprecated. Use Object.assign. ```

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the lodash.assign dependency #393

Remove the lodash.assign dependency #393

fson commented Sep 25, 2016 •

edited

hzoo commented Sep 27, 2016

fson commented Sep 27, 2016

jdalton Oct 10, 2016

Remove the lodash.assign dependency #393

Remove the lodash.assign dependency #393

Conversation

fson commented Sep 25, 2016 • edited

hzoo commented Sep 27, 2016

fson commented Sep 27, 2016

jdalton Oct 10, 2016

Choose a reason for hiding this comment

fson commented Sep 25, 2016 •

edited