Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Remove the lodash.assign dependency #393

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Remove the lodash.assign dependency #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
var babylonToEspree = require("./babylon-to-espree");
var assign = require("lodash.assign");
var pick = require("lodash.pickby");
var Module = require("module");
var path = require("path");
Expand Down Expand Up @@ -54,13 +53,13 @@ function monkeypatch() {
// monkeypatch estraverse
estraverse = estraverseRelative.require("estraverse");
estraverses.push(estraverse);
assign(estraverse.VisitorKeys, t.VISITOR_KEYS);
Object.assign(estraverse.VisitorKeys, t.VISITOR_KEYS);

// monkeypatch estraverse-fb (only for eslint < 2.3.0)
try {
var estraverseFb = eslintMod.require("estraverse-fb");
estraverses.push(estraverseFb);
assign(estraverseFb.VisitorKeys, t.VISITOR_KEYS);
Object.assign(estraverseFb.VisitorKeys, t.VISITOR_KEYS);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

} catch (err) {
// Ignore: ESLint v2.3.0 does not have estraverse-fb
}
Expand All @@ -69,7 +68,7 @@ function monkeypatch() {
var estraverseOfEslint = eslintMod.require("estraverse");
if (estraverseOfEslint !== estraverseFb) {
estraverses.push(estraverseOfEslint);
assign(estraverseOfEslint.VisitorKeys, t.VISITOR_KEYS);
Object.assign(estraverseOfEslint.VisitorKeys, t.VISITOR_KEYS);
}

estraverses.forEach(function (estraverse) {
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"babel-traverse": "^6.0.20",
"babel-types": "^6.0.19",
"babylon": "^6.11.2",
"lodash.assign": "^4.0.0",
"lodash.pickby": "^4.0.0"
},
"scripts": {
Expand Down
7 changes: 3 additions & 4 deletions test/integration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
var assert = require("assert");
var assign = require("lodash.assign");
var eslint = require("eslint");
var fs = require("fs");
var path = require("path");
Expand Down Expand Up @@ -56,7 +55,7 @@ function strictSuite () {
var ruleId = "strict";

describe("when set to 'never'", function () {
var eslintOpts = assign({}, baseEslintOpts, {
var eslintOpts = Object.assign({}, baseEslintOpts, {
rules: {},
});
eslintOpts.rules[ruleId] = [errorLevel, "never"];
Expand All @@ -81,7 +80,7 @@ function strictSuite () {
// describe

describe("when set to 'global'", function () {
var eslintOpts = assign({}, baseEslintOpts, {
var eslintOpts = Object.assign({}, baseEslintOpts, {
rules: {}
});
eslintOpts.rules[ruleId] = [errorLevel, "global"];
Expand Down Expand Up @@ -145,7 +144,7 @@ function strictSuite () {
// describe

describe("when set to 'function'", function () {
var eslintOpts = assign({}, baseEslintOpts, {
var eslintOpts = Object.assign({}, baseEslintOpts, {
rules: {}
});
eslintOpts.rules[ruleId] = [errorLevel, "function"];
Expand Down