Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Drop node < 4 #358

Merged
merged 1 commit into from
Aug 1, 2016
Merged

Drop node < 4 #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 0 additions & 15 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,8 @@ git:
depth: 1
sudo: false
language: node_js
before_install:
- sh -c "if [ '$ESLINT_VERSION' = '2' ]; then npm i --save-dev eslint@2; fi"
matrix:
include:
- node_js: "0.10"
env: ESLINT_VERSION=2
- node_js: "0.12"
env: ESLINT_VERSION=2
- node_js: "4"
env: ESLINT_VERSION=2
- node_js: "4"
env: ESLINT_VERSION=3
- node_js: "5"
env: ESLINT_VERSION=2
- node_js: "5"
env: ESLINT_VERSION=3
- node_js: "6"
env: ESLINT_VERSION=2
- node_js: "6"
env: ESLINT_VERSION=3
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
},
"author": "Sebastian McKenzie <sebmck@gmail.com>",
"license": "MIT",
"engines": {
"node": ">=4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be an upper limit placed here? Although it's probably pretty unlikely that a future Node would break this library, we can't know for sure until they're released :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a new node version breaks, we have to take action in any case. If it not breaks, then in this case we wouldn't have to do anything, but with limit we would always need to care. So I think it is fine like it is :)

},
"bugs": {
"url": "https://github.com/babel/babel-eslint/issues"
},
Expand Down