This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Allow eslint to define the babylon plugins #523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Sep 28, 2017
|
Yeah, I think there's a path forward there. If we land babel/babel#6332 and add a |
Closed
This was referenced Jan 8, 2018
|
I agree with @ljharb. Since parser plugins aren't configurable by the user, I don't think we should force users to keep track of this configuration for themselves. I'm going to try to find some time to look into this. |
|
WIP PR is open here: #711 All feedback welcome :) |
|
#711 has now landed |
|
Going to close since ^ landed! |
Graham42
added a commit
to Graham42/eslint-plugin-babel
that referenced
this pull request
Jan 29, 2019
Fixes: eslint/eslint#7534 Stage 3 Proposal: https://github.com/tc39/proposal-class-fields Babel plugin: https://babeljs.io/docs/en/babel-plugin-proposal-class-properties This does not yet support private class properties yet as that would require upgrading to babel-eslint@^11 which would require a bunch of other changes. See: babel/babel-eslint#523
brneto
added a commit
to brneto/todos-app
that referenced
this pull request
Apr 5, 2019
Turbo87
pushed a commit
to Turbo87/eslint-plugin-babel
that referenced
this pull request
Mar 30, 2020
Fixes: eslint/eslint#7534 Stage 3 Proposal: https://github.com/tc39/proposal-class-fields Babel plugin: https://babeljs.io/docs/en/babel-plugin-proposal-class-properties This does not yet support private class properties yet as that would require upgrading to babel-eslint@^11 which would require a bunch of other changes. See: babel/babel-eslint#523
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to use
babel-eslint, currently that means opting into every syntax feature that babylon offers. This allows you to provide your own array of babylon plugins in the eslintparserOptions. For us, this will allow us to enable stage-3 syntax features, but still make things like do-expressions a syntax error. If you don't define plugins, it'll default to enabling them all.