Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Clarify what all valid code means in readme #563

Closed
wants to merge 1 commit into from
Closed

Clarify what all valid code means in readme #563

wants to merge 1 commit into from

Conversation

the-spyke
Copy link
Sponsor

Fixes #555

@foiseworth
Copy link

Could we merge this? Lack of this information in the documentation caused me much confusion today

@kaicataldo
Copy link
Member

Just to note - this won't be true once this lands.

@kaicataldo
Copy link
Member

#711 has landed, making it so that babel-eslint will actually read the config file when parsing. I do agree we could clarify what this means, though!

@the-spyke
Copy link
Sponsor Author

I couldn't believe that it's still open.

@kaicataldo
Copy link
Member

Is it okay to close this PR? This is no longer true as of today's release.

@the-spyke
Copy link
Sponsor Author

Sure.

@the-spyke the-spyke closed this Jan 22, 2019
@the-spyke the-spyke deleted the clarify-how-it-works-section branch January 22, 2019 07:14
@the-spyke the-spyke mentioned this pull request Jan 22, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielweinmann danielweinmann danielweinmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@the-spyke @foiseworth @kaicataldo @danielweinmann