Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Add failing test for classPrivateMethods (regression) #776

Closed
wants to merge 1 commit into from
Closed

Add failing test for classPrivateMethods (regression) #776

wants to merge 1 commit into from

Conversation

mrtnzlml
Copy link

Hi, I read this PR #729 and this issue #728 and it seems like classPrivateMethods should work. However, it doesn't. So I added a failing test since I don't know how to fix it.

Thank you very much for checking it.

@anthonator
Copy link

Is there a workaround for this until this is fixed?

@justintime4tea
Copy link

justintime4tea commented Sep 20, 2019

Below is relevant for 10.0.3 apparently (and near that version? it's latest available on NPM...)

I don't know what the current issue is but if someone find this and is using an older (latest?) version like me then the below is what silenced my warning/error about it:

node_modules/babel-eslint/lib/parse.js
Right around line 21 is an array Plugins
Add "classPrivateMethods" to that list.

In newer code it looks like you should be able to pass something in. Haven't tried it but I'm not going to fill my projects with node dependencies from Git (other than our private repos that we must).

@omerdn1
Copy link

omerdn1 commented Dec 14, 2019

This issue is fixed in #801.
Hoping this gets merged soon.

@kaicataldo
Copy link
Member

Thank you for the PR. Now that @babel/eslint-parser has been released, we are making this repository read-only. If this is a change you would still like to advocate for, please reopen this in the babel/babel monorepo.

@kaicataldo kaicataldo closed this Aug 4, 2020
@mrtnzlml mrtnzlml deleted the failing-test-classPrivateMethods branch August 4, 2020 05:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants