fix: require eslint dependencies from eslint base #795
Conversation
# Conflicts: # lib/analyze-scope.js # package.json # yarn.lock
package.json
Outdated
| @@ -30,12 +30,11 @@ | |||
| ], | |||
| "peerDependencies": { | |||
| "@babel/core": ">=7.2.0", | |||
| "eslint": ">= 4.12.1" | |||
| "eslint": ">= 4.14.0" | |||
There was a problem hiding this comment.
Is this going to be released for v10 as well as v11? If this is going to be for v11, I wonder if it's worth dropping support for ESLint < 6?
There was a problem hiding this comment.
Nope, v10 does not include eslint-visitory-keys fixes, see #794 (comment)
If this is going to be for v11, I wonder if it's worth dropping support for ESLint < 6
We could drop ESLint < 6 support as long as we have a clear version policy, especially the timing when we will bump a major version. Do we bump after every major ESLint version? And what about every major babel version?
There was a problem hiding this comment.
I'm onboard with next major being ESLint >= 6
There was a problem hiding this comment.
I'm also ok with a policy of dropping in next major's when ESLint/Babel does if someone wants to make that PR
There was a problem hiding this comment.
For what it's worth, ESLint dropped support for Node < 8 in v6, now that it's out of maintenance mode.
A revised version of #794
Removed both
eslint-scopeandeslint-visitor-keysdependencies and bumped minimum ESLint requirement to>=4.14.0. Note that ESLint introduceeslint-visitor-keysdependency since 4.14.0