Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Add into 11.0.0 the fix from 10.0.2 to 10.0.3 #800

Closed
wants to merge 5 commits into from
Closed

Add into 11.0.0 the fix from 10.0.2 to 10.0.3 #800

wants to merge 5 commits into from

Conversation

agalatan
Copy link

@agalatan agalatan commented Sep 15, 2019

This PR just patches 11.0.0-beta.0 and versions it to 11.0.0-beta.1, in the exact same way 10.0.2 was patched and became 10.0.3

Problem:

  • babel-eslint@10.0.3 is being super weird for me (both eslint 5 & 6), in some Flow "edge cases", by reporting no-undef. But miraculously, babel-eslint@11.0.0-beta.0 fixes that problem.
  • Unfortunately, babel-eslint@11.0.0-beta.0 exhibits (for eslint < 6.2.0) the exact same issue as babel-eslint@10.0.2 did, which was fixed here: fix from 10.0.2 => 10.0.3

Solution:

  • Looking in the code for babel-eslint@11.0.0-beta.0, one can see this code is missing.

  • All I did in this PR was copy-paste, yarn, and version it to 11.0.0-beta.1

PS: This is my first PR

@agalatan agalatan changed the title Changes Add into 11.0.0 the fix from 10.0.2 to 10.0.3 Sep 15, 2019
Alin Galatan added 3 commits September 15, 2019 14:54
Ups forgot to yarn

Resolve fix
@tilgovi
Copy link

tilgovi commented Nov 24, 2019

Just came here to do the same :-D

@mwiencek
Copy link

mwiencek commented Dec 3, 2019

Any chance the wonderful maintainers can look into resolving this? :) I believe we had to switch to v11 beta to parse Flow's explicit inexact object type syntax {...}, but having no-unused-vars broken is unfortunate.

@kaicataldo
Copy link
Member

kaicataldo commented Dec 3, 2019

Hi! Sorry for the radio silence. We are in the process of getting babel-eslint updated and are developing a strategy to keep it maintainable going forward. You can follow along here.

@JLHwung
Copy link
Contributor

JLHwung commented Dec 10, 2019

Landed in 11.0.0-beta.2

npm install --save-dev babel-eslint@next

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants