Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests #1003

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update tests #1003

wants to merge 5 commits into from

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 31, 2023

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes: Migrate tests from callback to promise style.
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information: In preparation to the ESM migration, this PR migrates current tests from callback style to promise styles. We also add Node 20 to the CI matrix.

babel-loader 9 only supports webpack 5
In webpack 5.0.0, the mapObj.sources are

[
  'webpack://babel-loader/./test/fixtures/basic.js',
  'webpack://babel-loader/./test/fixtures/constant.js',
  'webpack://babel-loader/./test/fixtures/import.js',
  'webpack://babel-loader/webpack/bootstrap',
  'webpack://babel-loader/webpack/startup'
]

In later versions the `'webpack://babel-loader/./test/fixtures/basic.js'` is moved after webpack bootstrap, causing different indices across different webpack versions.
@JLHwung JLHwung mentioned this pull request Jul 31, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant