Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add all babel config files to file dependency #887

Merged
merged 1 commit into from Apr 3, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 9, 2020

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
In a webpack dev server, when babel.config.js is editted, files are not recompiled.

What is the new behavior?
They are now recompiled.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:
A follow-up to babel/babel#11907

Fixes #898

@JLHwung JLHwung merged commit eafd20d into main Apr 3, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the add-babel-config-as-file-dependency branch April 6, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger webpack re-compilation on Babel config change
2 participants