Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow instance properties transformation on namespace #5

Merged
merged 1 commit into from Sep 18, 2019

Conversation

thiagoarrais
Copy link
Collaborator

Trying to port babel/babel#10372

Please consider this as work-in-progress.

I've just started to port 10372, but I'm not really sure where and how to do it. Please let me know if there is something horribly out of place.

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Sep 12, 2019

Rather then in a polyfill provider, this should go in babel-plugin-inject-polyfills since it should be the same for all the providers, regardless of the polyfill that they are injecting.

https://github.com/nicolo-ribaudo/babel-polyfills/blob/6805c8d3427f9f0c6e6a44a1855a700b9b90a762/packages/babel-plugin-inject-polyfills/src/index.js#L200-L206

@thiagoarrais
Copy link
Collaborator Author

Thanks! That was exactly the kind of direction I needed. Will adapt the code as soon as possible.

@thiagoarrais
Copy link
Collaborator Author

I'm still undefined on where to move the tests to, but I've moved the namespace check to main injector.

@thiagoarrais
Copy link
Collaborator Author

Tests found a new home. I think this is done with 539242b. Just let me know if you need anything else.

@nicolo-ribaudo
Copy link
Member

Thanks! It's perfect 👍

@nicolo-ribaudo nicolo-ribaudo merged commit 849ea58 into babel:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants